“The idea of short-term pain for long-term gain is not a crazy idea in and of itself,” said Greg Mankiw, a Harvard economist who served as chairman of the Council of Economic Advisers under President George W. Bush. But Mr. Trump’s trade policies, he said, are “short-term pain to get more long-term pain.”